Conversation
… avoid race LegacyLibraryToolsService.trigger_duplication enqueued duplicate_children via Celery .delay(), but its only caller runs inside store.bulk_operations() in contentstore.utils.duplicate_block. With a real (non-eager) worker, the Celery task executes in another process before the bulk op commits, so store.get_item(dest_block_id) either raises ItemNotFoundError or returns a dest block with no children. The duplicated library_content block then renders the validation warning "There are no problems in the specified library of type any." Switch the call to duplicate_children.apply(kwargs=...), mirroring the identical fix applied to sync_from_library in #34029 / TNL-11339. The task now runs in the calling thread and observes the in-flight bulk operation. Also fix a self-comparison typo that made the cross-learning-context guard in trigger_duplication a silent no-op. Closes #36544
kingoftech-v01
requested review from
farhan,
irtazaakram and
salman2013
as code owners
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @kingoftech-v01! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
kingoftech-v01
changed the title
3 participants
Closed.